Delete content on flag approval

[akatsoulas]

No description provided.

[Copilot]

Pull Request Overview

This PR refactors the deletion behavior for flagged posts to streamline the content cleanup process upon flag approval. The changes update the user deletion handler to reassign authors instead of explicitly deleting flagged posts, add deletion logic to the FlaggedObject model’s save method to delete system user content upon flag approval, and introduce new tests to verify these behaviors.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
kitsune/forums/handlers.py	Removed explicit flagged post deletion logic and updated author instead.
kitsune/flagit/models.py	Added deletion logic in the save method for system users when a flag is approved.
kitsune/flagit/tests/test_models.py	Added tests covering deletion scenarios based on flag approval.

Comments suppressed due to low confidence (1)

kitsune/flagit/models.py:82

• Deleting both the content object and the flagged object directly in the save method may bypass post-delete signals or cleanup hooks. Consider reviewing this deletion order to ensure that all necessary cascading or signal-driven behavior is preserved.

self.delete()

[Copilot]

The previous logic explicitly deleted flagged posts while now all posts are simply updated. Please verify that flagged posts, which might require deletion upon flag approval, are handled as intended in the new design.

Suggested change

	def on_user_deletion(self, user: User) -> None:
	def on_user_deletion(self, user: User) -> None:
	# Delete flagged posts authored by the user
	Post.objects.filter(author=user, flagged=True).delete()
	# Update remaining posts to change the author to the bot user